-
Notifications
You must be signed in to change notification settings - Fork 357
fix(clerk-js): Do not display organization list after creating organization throw tasks flow #6117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(clerk-js): Do not display organization list after creating organization throw tasks flow #6117
Conversation
🦋 Changeset detectedLatest commit: e01d4f5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📝 Walkthrough""" WalkthroughThis change refactors the organization selection and creation flow within the Assessment against linked issues
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (5)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
42c4bce
to
7904177
Compare
7904177
to
f1f5250
Compare
f1f5250
to
c96f964
Compare
ff68c71
to
69324a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (1)
packages/clerk-js/src/ui/components/OrganizationList/OrganizationListPage.tsx (1)
273-289
: Add accessible status to the loading spinnerScreen-reader users receive no feedback during the blocking loading state.
Wrap the spinner in arole="status"
container or passaria-label
:- <Spinner - size={'lg'} - colorScheme={'primary'} - elementDescriptor={descriptors.spinner} - /> + <Spinner + size={'lg'} + colorScheme={'primary'} + elementDescriptor={descriptors.spinner} + role='status' + aria-label='Loading' + />This is a lightweight fix with zero visual impact.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.changeset/common-mice-ring.md
(1 hunks)packages/clerk-js/src/ui/components/OrganizationList/OrganizationListPage.tsx
(3 hunks)
🔇 Additional comments (1)
.changeset/common-mice-ring.md (1)
5-5
: Changelog entry looks goodNo issues; entry is concise and clear.
packages/clerk-js/src/ui/components/OrganizationList/OrganizationListPage.tsx
Outdated
Show resolved
Hide resolved
packages/clerk-js/src/ui/components/OrganizationList/OrganizationListPage.tsx
Outdated
Show resolved
Hide resolved
69324a6
to
d6269e6
Compare
c79f9fb
to
e4089cb
Compare
e4089cb
to
acf4b69
Compare
5fa7d86
to
d0d4128
Compare
d0d4128
to
c646c72
Compare
c646c72
to
eb33aef
Compare
eb33aef
to
e01d4f5
Compare
Resolves ORGS-683, ORGS-705
Issue
Currently, when creating an organization during the force-an-org step, it re-renders
OrganizationList
to display the list of memberships. This display is shown for a couple of seconds until the navigation toredirectUrlComplete
is complete.Solution
This PR introduces a separate chunk of UI for the
force-an-org
step, in which gets rendered only if it's inside aSessionTasks
flow. With that, it can run a different logic to not display the list of memberships after creation, but only if there are no organization memberships attached to the session.CleanShot.2025-06-18.at.11.36.50.mp4
Checklist
pnpm test
runs as expected.pnpm build
runs as expected.Type of change
Summary by CodeRabbit
New Features
Bug Fixes
Improvements
Chores