Closed
Conversation
🦋 Changeset detectedLatest commit: 0e34026 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After trying out https://tsdown.dev/ in a couple of OSS projects of mine I was curious what it would take to migrate our usage of tsup to it here.
In my personal testing I saw that with
isolatedDeclarationsyou run into problems like microsoft/TypeScript#58944 where complex computed types (e.g. through Zod) would need to be written out. In general, enabling this option would effectively force us to enable https://typescript-eslint.io/rules/explicit-function-return-type/. Not necessarily a bad thing to do, but something we have to decide on.tsdown is I think nearly on par with tsup in terms of what we need from it (except for the edge cases). I was excited to read in https://tsdown.dev/guide/dts that also declaration map generation is available. We need those for Typedoc generation.
Here's a speed comparison on my personal MacBook:
tsup
tsdown
➜ hyperfine 'pnpm build' Benchmark 1: pnpm build Time (mean ± σ): 778.6 ms ± 26.9 ms [User: 1268.8 ms, System: 160.9 ms] Range (min … max): 745.8 ms … 822.1 ms 10 runsAs you can see, much faster! The
typespackage is a good candidate for theisolatedDeclarationsoption but even without it tsdown should generally be faster. Especially if we need to generate declarations for it, too.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change