-
Notifications
You must be signed in to change notification settings - Fork 359
feat(kk-KZ.ts): add Kazakh (kk-KZ) language #5684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@azekowka is attempting to deploy a commit to the Clerk Production Team on Vercel. A member of the Team first needs to authorize it. |
Hello 👋 We currently close PRs after 60 days of inactivity. It's been 50 days since the last update here. If we missed this PR, please reply here. Otherwise, we'll close this PR in 10 days. Thanks for being a part of the Clerk community! 🙏 |
📝 WalkthroughWalkthroughA new Kazakh language localization file has been introduced, providing translations for various user interface strings related to authentication, user management, billing, subscriptions, and error handling. The file exports a typed constant containing structured translation keys, supporting dynamic placeholders and comprehensive coverage of application features. Changes
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/localizations/src/kk-KZ.ts
(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
packages/localizations/src/kk-KZ.ts (1)
packages/types/src/localization.ts (1)
LocalizationResource
(14-14)
🔇 Additional comments (3)
packages/localizations/src/kk-KZ.ts (3)
1-4
: Good import and export
TheLocalizationResource
import and thekkKZ
constant declaration follow the established pattern and thelocale
property matches the file name.
9-11
: Verify distinct checkout messages
Bothdescription__paymentSuccessful
anddescription__subscriptionSuccessful
use the same translation. Confirm that the subscription success message is intentionally identical or update it to reflect a subscription-specific text.
1-998
: Verify localization key consistency
Ensure thatkkKZ
includes the same set of keys (and nesting structure) as other locale files (e.g.,en.ts
). This helps prevent missing or extra translations.
formFieldInputPlaceholder__organizationSlug: 'my-org', | ||
formFieldInputPlaceholder__password: 'Құпия сөзді енгізіңіз', | ||
formFieldInputPlaceholder__phoneNumber: 'Телефон нөмірін енгізіңіз', | ||
formFieldInputPlaceholder__username: undefined, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace undefined placeholder
formFieldInputPlaceholder__username
is set to undefined
, which can result in "undefined" appearing in the UI. Use an empty string or a valid translation.
-formFieldInputPlaceholder__username: undefined,
+formFieldInputPlaceholder__username: '',
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
formFieldInputPlaceholder__organizationSlug: 'my-org', | |
formFieldInputPlaceholder__password: 'Құпия сөзді енгізіңіз', | |
formFieldInputPlaceholder__phoneNumber: 'Телефон нөмірін енгізіңіз', | |
formFieldInputPlaceholder__username: undefined, | |
formFieldInputPlaceholder__organizationSlug: 'my-org', | |
formFieldInputPlaceholder__password: 'Құпия сөзді енгізіңіз', | |
formFieldInputPlaceholder__phoneNumber: 'Телефон нөмірін енгізіңіз', | |
- formFieldInputPlaceholder__username: undefined, | |
+ formFieldInputPlaceholder__username: '', |
🤖 Prompt for AI Agents
In packages/localizations/src/kk-KZ.ts around lines 80 to 83, the property
formFieldInputPlaceholder__username is assigned undefined, which may cause
"undefined" to appear in the UI. Replace the undefined value with an empty
string or provide a valid Kazakh translation for the username placeholder to
ensure proper display.
badge__endsAt: "{{ date | shortDate('en-US') }} күні аяқталады", | ||
badge__expired: 'Мерзімі біткен', | ||
badge__otherImpersonatorDevice: 'Басқа эмуляциялаушы құрылғы', | ||
badge__primary: 'Негізгі', | ||
badge__requiresAction: 'Әрекет қажет', | ||
badge__startsAt: "{{ date | shortDate('en-US') }} күні басталады", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Date placeholders use wrong locale
The shortDate
pipe is still using 'en-US'
. Update these to 'kk-KZ'
so dates are formatted correctly for Kazakh users.
-badge__endsAt: "{{ date | shortDate('en-US') }} күні аяқталады",
+badge__endsAt: "{{ date | shortDate('kk-KZ') }} күні аяқталады",
-badge__startsAt: "{{ date | shortDate('en-US') }} күні басталады",
+badge__startsAt: "{{ date | shortDate('kk-KZ') }} күні басталады",
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
badge__endsAt: "{{ date | shortDate('en-US') }} күні аяқталады", | |
badge__expired: 'Мерзімі біткен', | |
badge__otherImpersonatorDevice: 'Басқа эмуляциялаушы құрылғы', | |
badge__primary: 'Негізгі', | |
badge__requiresAction: 'Әрекет қажет', | |
badge__startsAt: "{{ date | shortDate('en-US') }} күні басталады", | |
badge__endsAt: "{{ date | shortDate('kk-KZ') }} күні аяқталады", | |
badge__expired: 'Мерзімі біткен', | |
badge__otherImpersonatorDevice: 'Басқа эмуляциялаушы құрылғы', | |
badge__primary: 'Негізгі', | |
badge__requiresAction: 'Әрекет қажет', | |
badge__startsAt: "{{ date | shortDate('kk-KZ') }} күні басталады", |
🤖 Prompt for AI Agents
In packages/localizations/src/kk-KZ.ts around lines 32 to 37, the date
placeholders use the 'en-US' locale in the shortDate pipe, which is incorrect
for Kazakh localization. Update the locale string from 'en-US' to 'kk-KZ' in all
instances of the shortDate pipe to ensure dates are formatted properly for
Kazakh users.
dates: { | ||
lastDay: "Кеше {{ date | timeString('en-US') }}", | ||
next6Days: "{{ date | weekday('en-US','long') }} {{ date | timeString('en-US') }}", | ||
nextDay: "Ертең {{ date | timeString('en-US') }}", | ||
numeric: "{{ date | numeric('en-US') }}", | ||
previous6Days: "Өткен {{ date | weekday('en-US','long') }} {{ date | timeString('en-US') }}", | ||
sameDay: "Бүгін {{ date | timeString('en-US') }}", | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dates section uses en-US formatting
All date/time pipes in the dates
section reference 'en-US'
. They should be updated to 'kk-KZ'
to ensure proper localization.
@@ dates:
- lastDay: "Кеше {{ date | timeString('en-US') }}",
+ lastDay: "Кеше {{ date | timeString('kk-KZ') }}",
- next6Days: "{{ date | weekday('en-US','long') }} {{ date | timeString('en-US') }}",
+ next6Days: "{{ date | weekday('kk-KZ','long') }} {{ date | timeString('kk-KZ') }}",
- nextDay: "Ертең {{ date | timeString('en-US') }}",
+ nextDay: "Ертең {{ date | timeString('kk-KZ') }}",
- numeric: "{{ date | numeric('en-US') }}",
+ numeric: "{{ date | numeric('kk-KZ') }}",
- previous6Days: "Өткен {{ date | weekday('en-US','long') }} {{ date | timeString('en-US') }}",
+ previous6Days: "Өткен {{ date | weekday('kk-KZ','long') }} {{ date | timeString('kk-KZ') }}",
- sameDay: "Бүгін {{ date | timeString('en-US') }}",
+ sameDay: "Бүгін {{ date | timeString('kk-KZ') }}",
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
dates: { | |
lastDay: "Кеше {{ date | timeString('en-US') }}", | |
next6Days: "{{ date | weekday('en-US','long') }} {{ date | timeString('en-US') }}", | |
nextDay: "Ертең {{ date | timeString('en-US') }}", | |
numeric: "{{ date | numeric('en-US') }}", | |
previous6Days: "Өткен {{ date | weekday('en-US','long') }} {{ date | timeString('en-US') }}", | |
sameDay: "Бүгін {{ date | timeString('en-US') }}", | |
}, | |
dates: { | |
lastDay: "Кеше {{ date | timeString('kk-KZ') }}", | |
next6Days: "{{ date | weekday('kk-KZ','long') }} {{ date | timeString('kk-KZ') }}", | |
nextDay: "Ертең {{ date | timeString('kk-KZ') }}", | |
numeric: "{{ date | numeric('kk-KZ') }}", | |
previous6Days: "Өткен {{ date | weekday('kk-KZ','long') }} {{ date | timeString('kk-KZ') }}", | |
sameDay: "Бүгін {{ date | timeString('kk-KZ') }}", | |
}, |
🤖 Prompt for AI Agents
In packages/localizations/src/kk-KZ.ts around lines 50 to 57, all date/time
formatting pipes currently use the 'en-US' locale, which is incorrect for this
Kazakh localization file. Update each instance of 'en-US' in the dates section
to 'kk-KZ' to ensure proper localization of date and time formats.
Description
Checklist
pnpm test
runs as expected.pnpm build
runs as expected.Type of change
Summary by CodeRabbit