Skip to content

feat(kk-KZ.ts): add Kazakh (kk-KZ) language #5684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

azekowka
Copy link

@azekowka azekowka commented Apr 20, 2025

Description

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • New Features
    • Added Kazakh language support, providing comprehensive translations for authentication, user profiles, organizations, billing, subscriptions, error messages, and account management interfaces.

Copy link

changeset-bot bot commented Apr 20, 2025

⚠️ No Changeset found

Latest commit: 8da5dde

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 20, 2025

@azekowka is attempting to deploy a commit to the Clerk Production Team on Vercel.

A member of the Team first needs to authorize it.

@clerk-cookie
Copy link
Collaborator

Hello 👋

We currently close PRs after 60 days of inactivity. It's been 50 days since the last update here. If we missed this PR, please reply here. Otherwise, we'll close this PR in 10 days.

Thanks for being a part of the Clerk community! 🙏

Copy link
Contributor

coderabbitai bot commented Jun 10, 2025

📝 Walkthrough

Walkthrough

A new Kazakh language localization file has been introduced, providing translations for various user interface strings related to authentication, user management, billing, subscriptions, and error handling. The file exports a typed constant containing structured translation keys, supporting dynamic placeholders and comprehensive coverage of application features.

Changes

Files Change Summary
packages/localizations/src/kk-KZ.ts Added new Kazakh localization resource file exporting a typed constant with comprehensive UI translations.
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0ae0403 and 8da5dde.

📒 Files selected for processing (1)
  • packages/localizations/src/kk-KZ.ts (1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
packages/localizations/src/kk-KZ.ts (1)
packages/types/src/localization.ts (1)
  • LocalizationResource (14-14)
🔇 Additional comments (3)
packages/localizations/src/kk-KZ.ts (3)

1-4: Good import and export
The LocalizationResource import and the kkKZ constant declaration follow the established pattern and the locale property matches the file name.


9-11: Verify distinct checkout messages
Both description__paymentSuccessful and description__subscriptionSuccessful use the same translation. Confirm that the subscription success message is intentionally identical or update it to reflect a subscription-specific text.


1-998: Verify localization key consistency
Ensure that kkKZ includes the same set of keys (and nesting structure) as other locale files (e.g., en.ts). This helps prevent missing or extra translations.

Comment on lines +80 to +83
formFieldInputPlaceholder__organizationSlug: 'my-org',
formFieldInputPlaceholder__password: 'Құпия сөзді енгізіңіз',
formFieldInputPlaceholder__phoneNumber: 'Телефон нөмірін енгізіңіз',
formFieldInputPlaceholder__username: undefined,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Replace undefined placeholder
formFieldInputPlaceholder__username is set to undefined, which can result in "undefined" appearing in the UI. Use an empty string or a valid translation.

-formFieldInputPlaceholder__username: undefined,
+formFieldInputPlaceholder__username: '',
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
formFieldInputPlaceholder__organizationSlug: 'my-org',
formFieldInputPlaceholder__password: 'Құпия сөзді енгізіңіз',
formFieldInputPlaceholder__phoneNumber: 'Телефон нөмірін енгізіңіз',
formFieldInputPlaceholder__username: undefined,
formFieldInputPlaceholder__organizationSlug: 'my-org',
formFieldInputPlaceholder__password: 'Құпия сөзді енгізіңіз',
formFieldInputPlaceholder__phoneNumber: 'Телефон нөмірін енгізіңіз',
- formFieldInputPlaceholder__username: undefined,
+ formFieldInputPlaceholder__username: '',
🤖 Prompt for AI Agents
In packages/localizations/src/kk-KZ.ts around lines 80 to 83, the property
formFieldInputPlaceholder__username is assigned undefined, which may cause
"undefined" to appear in the UI. Replace the undefined value with an empty
string or provide a valid Kazakh translation for the username placeholder to
ensure proper display.

Comment on lines +32 to +37
badge__endsAt: "{{ date | shortDate('en-US') }} күні аяқталады",
badge__expired: 'Мерзімі біткен',
badge__otherImpersonatorDevice: 'Басқа эмуляциялаушы құрылғы',
badge__primary: 'Негізгі',
badge__requiresAction: 'Әрекет қажет',
badge__startsAt: "{{ date | shortDate('en-US') }} күні басталады",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Date placeholders use wrong locale
The shortDate pipe is still using 'en-US'. Update these to 'kk-KZ' so dates are formatted correctly for Kazakh users.

-badge__endsAt: "{{ date | shortDate('en-US') }} күні аяқталады",
+badge__endsAt: "{{ date | shortDate('kk-KZ') }} күні аяқталады",
-badge__startsAt: "{{ date | shortDate('en-US') }} күні басталады",
+badge__startsAt: "{{ date | shortDate('kk-KZ') }} күні басталады",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
badge__endsAt: "{{ date | shortDate('en-US') }} күні аяқталады",
badge__expired: 'Мерзімі біткен',
badge__otherImpersonatorDevice: 'Басқа эмуляциялаушы құрылғы',
badge__primary: 'Негізгі',
badge__requiresAction: 'Әрекет қажет',
badge__startsAt: "{{ date | shortDate('en-US') }} күні басталады",
badge__endsAt: "{{ date | shortDate('kk-KZ') }} күні аяқталады",
badge__expired: 'Мерзімі біткен',
badge__otherImpersonatorDevice: 'Басқа эмуляциялаушы құрылғы',
badge__primary: 'Негізгі',
badge__requiresAction: 'Әрекет қажет',
badge__startsAt: "{{ date | shortDate('kk-KZ') }} күні басталады",
🤖 Prompt for AI Agents
In packages/localizations/src/kk-KZ.ts around lines 32 to 37, the date
placeholders use the 'en-US' locale in the shortDate pipe, which is incorrect
for Kazakh localization. Update the locale string from 'en-US' to 'kk-KZ' in all
instances of the shortDate pipe to ensure dates are formatted properly for
Kazakh users.

Comment on lines +50 to +57
dates: {
lastDay: "Кеше {{ date | timeString('en-US') }}",
next6Days: "{{ date | weekday('en-US','long') }} {{ date | timeString('en-US') }}",
nextDay: "Ертең {{ date | timeString('en-US') }}",
numeric: "{{ date | numeric('en-US') }}",
previous6Days: "Өткен {{ date | weekday('en-US','long') }} {{ date | timeString('en-US') }}",
sameDay: "Бүгін {{ date | timeString('en-US') }}",
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Dates section uses en-US formatting
All date/time pipes in the dates section reference 'en-US'. They should be updated to 'kk-KZ' to ensure proper localization.

@@ dates:
- lastDay: "Кеше {{ date | timeString('en-US') }}",
+ lastDay: "Кеше {{ date | timeString('kk-KZ') }}",
- next6Days: "{{ date | weekday('en-US','long') }} {{ date | timeString('en-US') }}",
+ next6Days: "{{ date | weekday('kk-KZ','long') }} {{ date | timeString('kk-KZ') }}",
- nextDay: "Ертең {{ date | timeString('en-US') }}",
+ nextDay: "Ертең {{ date | timeString('kk-KZ') }}",
- numeric: "{{ date | numeric('en-US') }}",
+ numeric: "{{ date | numeric('kk-KZ') }}",
- previous6Days: "Өткен {{ date | weekday('en-US','long') }} {{ date | timeString('en-US') }}",
+ previous6Days: "Өткен {{ date | weekday('kk-KZ','long') }} {{ date | timeString('kk-KZ') }}",
- sameDay: "Бүгін {{ date | timeString('en-US') }}",
+ sameDay: "Бүгін {{ date | timeString('kk-KZ') }}",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
dates: {
lastDay: "Кеше {{ date | timeString('en-US') }}",
next6Days: "{{ date | weekday('en-US','long') }} {{ date | timeString('en-US') }}",
nextDay: "Ертең {{ date | timeString('en-US') }}",
numeric: "{{ date | numeric('en-US') }}",
previous6Days: "Өткен {{ date | weekday('en-US','long') }} {{ date | timeString('en-US') }}",
sameDay: "Бүгін {{ date | timeString('en-US') }}",
},
dates: {
lastDay: "Кеше {{ date | timeString('kk-KZ') }}",
next6Days: "{{ date | weekday('kk-KZ','long') }} {{ date | timeString('kk-KZ') }}",
nextDay: "Ертең {{ date | timeString('kk-KZ') }}",
numeric: "{{ date | numeric('kk-KZ') }}",
previous6Days: "Өткен {{ date | weekday('kk-KZ','long') }} {{ date | timeString('kk-KZ') }}",
sameDay: "Бүгін {{ date | timeString('kk-KZ') }}",
},
🤖 Prompt for AI Agents
In packages/localizations/src/kk-KZ.ts around lines 50 to 57, all date/time
formatting pipes currently use the 'en-US' locale, which is incorrect for this
Kazakh localization file. Update each instance of 'en-US' in the dates section
to 'kk-KZ' to ensure proper localization of date and time formats.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants