fix(e2e): Disable testing token for flaky test#5672
Closed
panteliselef wants to merge 2 commits into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
🦋 Changeset detectedLatest commit: 6c6d91b The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
|
Nice find @panteliselef 👏🏼 . It might be a good idea to surface some debug log whenever we intercept routes behind the scenes to at least make it a little more transparent about what's going on |
jacekradko
approved these changes
Apr 19, 2025
9 tasks
Contributor
Author
|
handled by #5673 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
@clerk/testingpackage is overriding.route()rules for our tests cases inconsistently. Example:our tests either abort or fulfill with a dummy response, but the
@clerk/testingmay fulfill with the actual response due to a race condition.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change