Open
Conversation
60822b9 to
01e8bdf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tiling.save_tilesandTarTileReader, while keeping HS2P coordinate artifacts as the canonical tiling metadatatiles_*coordinate files tocoordinates_*, update docs, and add focused regression coverage for the new tile-store pathValidation
COVERAGE_FILE=/tmp/slide2vec-region-final.coverage ~/Code/venv/slide2vec/bin/python -m pytest -q tests/test_dependency_split.py tests/test_regression_inference.py tests/test_progress.py -k 'region_batch_preprocessor or region_models or serialize_execution or uses_batched_loader_knobs or batch_timing or run_forward_pass or dependency_split'COVERAGE_FILE=/tmp/slide2vec-backend-split.coverage ~/Code/venv/slide2vec/bin/python -m pytest -q tests/test_regression_core.py tests/test_regression_inference.py -k 'execution_options_from_config or execution_options_with_output_dir or serialize_execution or build_hs2p_configs or resolve_embedding_backend or uses_batched_loader_knobs'COVERAGE_FILE=/tmp/slide2vec-push.coverage ~/Code/venv/slide2vec/bin/python -m pytest -q tests/test_hs2p_package_cutover.py -k 'load_process_df_requires_hs2p_process_list_columns'~/Code/venv/slide2vec/bin/python -m py_compile slide2vec/api.py slide2vec/data/tile_store.py slide2vec/data/dataset.py slide2vec/inference.py slide2vec/utils/tiling_io.py tests/test_tile_store.pyNotes
tests/test_tile_store.pywas added for the tar-backed reader, but this local venv is missingPIL, so I did not run that file here..claude/settings.local.jsonremains local and was not included in the branch.