Persist local embedding progress on failure#74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Local single-process embedding used to batch all persistence until the entire embedding stage finished. If a later slide failed, earlier successful slides had been computed in memory but nothing had been written yet, so the run lost all embedding progress.
This change makes local embedding durable and resumable:
process_list.csvfeature and aggregation status aligned with the artifacts that have actually been writtenPipeline.run(...)is rerun withresume=True, skip slides whose local embedding artifacts are already complete and marked successfulembed_slides(..., output_dir=...)durable on later-slide failureUser impact
If a large local batch fails near the end, the embeddings that finished before the failure stay on disk instead of being discarded. A resumed local pipeline run now reuses those completed artifacts and computes only the remaining slides.