Fraction output v2 #593
Open
Fraction output v2 #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/src/main/java/com/darkempire78/opencalculator/MyPreferences.kt # app/src/main/java/com/darkempire78/opencalculator/activities/MainActivity.kt
# Conflicts: # app/src/main/java/com/darkempire78/opencalculator/MyPreferences.kt # app/src/main/java/com/darkempire78/opencalculator/activities/MainActivity.kt
|
The PR looks very good, i just see that:
|
|
@bmg1919 is it intentional to remove the "live calculation" ? |
Not originally no. I'm correcting it now. |
|
I found my error and found one or two others in the fraction function. At the present time, it only converts the final result to a fraction on pressing '='. On equals, it displays both decimal and fraction answers. |
|
I've now updated it so that fractions show in the live result. '=' now shows decimal value on top and fraction below. I kind of like having both results on screen but can attempt adjustment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New PR to replace #535