-
Notifications
You must be signed in to change notification settings - Fork 1
Add getter functions for TLM defaults #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs more tests
A test, unrelated to this PR, is failing.
It's because of the ordering in {'criteria', 'name'}. Let me know if this is expected (and should let it be), or if I should update this test to work independent of the ordering. |
You can ignore, unless you have clear idea of how to fix it yourself |
…_TLM_MAX_TOKENS`, and lint
…d tokenization checks instead of tiktoken
tests/test_config.py
Outdated
response = result["response"] | ||
assert isinstance(response, str) | ||
|
||
enc = tiktoken.encoding_for_model(get_default_model()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you confirm this code will still work:
s = “gpt-4.1-mini”
enc = tiktoken.encoding_for_model(get_default_model(s))
because we're going to shortly be upgrading the default model
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code will not work at the moment because of a pending PR openai/tiktoken#396
Though, its confirmed that 4.1-* uses the same tokenizer as 4o here
When we upgrade to 4.1, we can spoof / hardcode to fetch gpt-4o tokenizer (just setting a variable) until the above PR gets merged.
Let me know if you want me to do this as part of this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep I made the suggestion in the code, if you can fix it up / test it works still
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming these comments are satisfied:
Co-authored-by: Jonas Mueller <[email protected]>
Key Info
What changed?
What do you want the reviewer(s) to focus on?
Checklist