Update deprecated calls to exists? alias#50
Open
mathisto wants to merge 1 commit intocldwalker:masterfrom
Open
Update deprecated calls to exists? alias#50mathisto wants to merge 1 commit intocldwalker:masterfrom
mathisto wants to merge 1 commit intocldwalker:masterfrom
Conversation
Turn off auto format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You I
exists?I am afraid the answer is no; not any longer.Modern versions of ruby have finally dropped the long deprecated pluralized alias
exists?in favor of the preferredexist?form.This PR updates the two usages in the codebase to use the singular (non-deprecated) form. This should work on older versions, since the pluralized form was an alias, but also on new versions of ruby that removed the alias. Everyone wins!