Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump React 19 version, remove prop-types from main component. #571

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

Mati365
Copy link
Member

@Mati365 Mati365 commented Feb 4, 2025

Suggested merge commit message (convention)

Fix: data prop is no longer unavailable in Next.js related integrations. Closes #567
Other: Remove prop-types from dependencies of package.

@Witoso
Copy link
Member

Witoso commented Feb 4, 2025

https://github.com/facebook/prop-types was archived by facebook and is not maintained.

@Witoso
Copy link
Member

Witoso commented Feb 4, 2025

Should we bump to 19? https://majors.nullvoxpopuli.com/q?minors=false&old=false&packages=react

Would this cause disruptions for us developing against 18?

@Mati365
Copy link
Member Author

Mati365 commented Feb 4, 2025

@Witoso Nope, absence of this package does nothing. Runtime validation of the props is no longer relevant in TypeScript era. I kept prop-types as dev dependency because our linter tends to use it.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 49d3cb40-1081-4206-bde5-592d30f849bf

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build d1d449e2-0d3b-461f-abbc-d57ee462a2bf: 0.0%
Covered Lines: 590
Relevant Lines: 590

💛 - Coveralls

Copy link

@gorzelinski gorzelinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working fine now.

@Mati365 Mati365 merged commit 2a7d015 into master Feb 4, 2025
5 checks passed
@Mati365 Mati365 deleted the ck/567 branch February 4, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data prop is not available for ckeditor
4 participants