Mumble tweaks/fixes #3058
Open
Mumble tweaks/fixes #3058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
triage
AvarianKnight
force-pushed
the
tweak/mumble-tweaks
branch
3 times, most recently
from
1c1dbe5 to
55cb212
Compare
AvarianKnight
force-pushed
the
tweak/mumble-tweaks
branch
from
55cb212 to
ca7afc8
Compare
github-actions
bot
added
invalid
|
This should be ready to be reviewed now, newer changes remove conversions between string types and resets the players mumble connection if the server doesn't respond to TCP pings. |
AvarianKnight
force-pushed
the
tweak/mumble-tweaks
branch
from
ca7afc8 to
bad5800
Compare
AvarianKnight
changed the title
AvarianKnight
force-pushed
the
tweak/mumble-tweaks
branch
from
bad5800 to
ebfb2f4
Compare
…eTarget packet - The previous implementation allowed duplicates, and was more complex than what we need since we don't care about channel linking (we would always set it to false) - This will also reset connections if they have too many in flight TCP pings - This removes all the swaps from std::wstring <-> std::string
AvarianKnight
force-pushed
the
tweak/mumble-tweaks
branch
from
ebfb2f4 to
33651e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Fix some possible edge cases where players could be invalid but we would still send a properly formatted mumble name
Removes swapping between
std::wstringandstd::stringReset the mumble connection in cases where the client loses their TCP connection.
Fix some cases where the client would send duplicates of the same targets to the server, leading to some excessively large packets.
Wrap any native that needs to be used while connected in
MakeMumbleNativeThis change set is currently untested
This PR applies to the following area(s)
FiveM, RedM
Successfully tested on
Game builds: ..
Checklist