Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak(cfx/nui): Introduce ServerReviewsEnabled convar #2985

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

IllInuz
Copy link

@IllInuz IllInuz commented Dec 6, 2024

Add convar for ServerReviewsEnabled (Boolean) true/false to enable or disable reviews.

Goal of this PR

Allows server owners to set a convar ServerReviewsEnabled to either true or false (default to true).
This will then allow/deny from new reviews being posted/submitted.

...

How is this PR achieving the goal

By introducing a new convar ServerReviewsEnabled, if set to true it will allow new reviews, if set to false it will not allow these to be submitted.
...

This PR applies to the following area(s)

FiveM
...

Successfully tested on

Successfull compilation on local build.

Game builds: ..

Platforms: Windows

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Fixes issues

#2979 - Will be fixed by not hardlocking it, but rather allowing server owners themselves to decide.

Add convar for ServerReviewsEnabled (Boolean) true/false to enable or disable reviews.
@github-actions github-actions bot added the invalid Requires changes before it's considered valid and can be (re)triaged label Dec 6, 2024
@IllInuz IllInuz changed the title Update transformers.ts tweak(cfx/nui): Introduce ServerReviewsEnabled convar Dec 6, 2024
@outsider31000
Copy link
Contributor

You Should try make it consistent using underscores and perhaps starting with sv*

@IllInuz
Copy link
Author

IllInuz commented Dec 6, 2024

You Should try make it consistent using underscores and perhaps starting with sv*

Not all convars start with sv_, though i get the point, thing is, this is up to the elements to get merged; i just presented them with an example!

@keeganwut
Copy link

keeganwut commented Dec 7, 2024

I think it'd be neat to see a convar to set a playtime needed on the server to be able to review, I think the launcher already tracks user playtime somewhere. Maybe even like a forum account age thing, I'm unsure what data the server has access to.

The review system is really useful but bots and inaccurate reviews can plague it and ultimately make it pointless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid Requires changes before it's considered valid and can be (re)triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants