More resilient UFC parsing #750
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rely on the 'flashing' behavior of the UFC when a value gets processed, instead of hoping for an ENT key to register. sidefix: correclty disables MIDS if L16 gets subsenquently disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rely on the 'flashing' behavior of the UFC when a value gets processed, instead of hoping for an ENT key to register.
The main benefit is extra stability vis-a-vis Exports, since it removes the dependencies on LuaExportBeforeNextFrame (if this is borked, we only lose LOS stuff).
sidefix: correctly disables MIDS if L16 gets subsenquently disabled.
The gist is to look for the flash,: UFC has value, gets cleared, and gets either value again or ERROR.
We detect the ERROR message as needed, and do nothing if that happens.
It also consolidates how IFF is parsed, fixing escaping the
-character in thestring.matchfor those (should have been%-).Lastly, it accomodates for cases where the display will add/remove leading zeroes by interpreting values as numbers.