Skip to content

Avoid enumerating all cameras when specific device requested #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrewseddon wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Avoid enumerating all cameras when specific device requested #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 41 additions & 34 deletions ext/pylon/gstpylon.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,46 +232,53 @@ GstPylon *gst_pylon_new(GstElement *gstpylonsrc, const gchar *device_user_name,
filter[0].SetSerialNumber(device_serial_number);
}

factory.EnumerateDevices(device_list, filter);
bool open_direct =
(device_user_name || device_serial_number) && (-1 == device_index);

gint n_devices = device_list.size();
if (0 == n_devices) {
throw Pylon::GenericException(
"No devices found matching the specified criteria", __FILE__,
__LINE__);
}
if (!open_direct) {
factory.EnumerateDevices(device_list, filter);

if (n_devices > 1 && -1 == device_index) {
std::string msg =
"At least " + std::to_string(n_devices) +
" devices match the specified criteria, use "
"\"device-index\", \"device-serial-number\" or \"device-user-name\""
" to select one from the following list:\n";

for (gint i = 0; i < n_devices; i++) {
msg += "[" + std::to_string(i) +
"]: " + std::string(device_list.at(i).GetSerialNumber()) + "\t" +
std::string(device_list.at(i).GetModelName()) + "\t" +
std::string(device_list.at(i).GetUserDefinedName()) + "\n";
gint n_devices = device_list.size();
if (0 == n_devices) {
throw Pylon::GenericException(
"No devices found matching the specified criteria", __FILE__,
__LINE__);
}
throw Pylon::GenericException(msg.c_str(), __FILE__, __LINE__);
}

if (device_index >= n_devices) {
std::string msg = "Device index " + std::to_string(device_index) +
" exceeds the " + std::to_string(n_devices) +
" devices found to match the given criteria";
throw Pylon::GenericException(msg.c_str(), __FILE__, __LINE__);
}
if (n_devices > 1 && -1 == device_index) {
std::string msg =
"At least " + std::to_string(n_devices) +
" devices match the specified criteria, use "
"\"device-index\", \"device-serial-number\" or \"device-user-name\""
" to select one from the following list:\n";

for (gint i = 0; i < n_devices; i++) {
msg += "[" + std::to_string(i) +
"]: " + std::string(device_list.at(i).GetSerialNumber()) +
"\t" + std::string(device_list.at(i).GetModelName()) + "\t" +
std::string(device_list.at(i).GetUserDefinedName()) + "\n";
}
throw Pylon::GenericException(msg.c_str(), __FILE__, __LINE__);
}

/* Only one device was found, we don't require the user specifying an
* index
* and if they did, we already checked for out-of-range errors above */
if (1 == n_devices) {
device_index = 0;
}
if (device_index >= n_devices) {
std::string msg = "Device index " + std::to_string(device_index) +
" exceeds the " + std::to_string(n_devices) +
" devices found to match the given criteria";
throw Pylon::GenericException(msg.c_str(), __FILE__, __LINE__);
}

/* Only one device was found, we don't require the user specifying an
* index and if they did, we already checked for out-of-range errors
* above */
if (1 == n_devices) {
device_index = 0;
}

device_info = device_list.at(device_index);
device_info = device_list.at(device_index);
} else {
device_info = filter[0];
}

/* retry loop to start camera
* handles the cornercase of multiprocess pipelines started
Expand Down