Skip to content

Fix errors in shell-scripts, make installation ask permission before modifying bashrc, make POSIX-compatible #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ELLIOTTCABLE
Copy link

@ELLIOTTCABLE ELLIOTTCABLE commented Jan 17, 2025

Cleaned up the shell-scripts subsantially:

  • Missing quotes were causing this to fail when installed on systems with spaces in the paths
  • The install scripts now ask permission before modifying .bashrc, and provide instructions if that permission is denied
  • All the scripts are now POSIX-compliant, and do not depend on bash
  • The README used curl ... | sh, which is slightly less safe than sh -c "$(curl ...)"r
  • While at it, I cleaned up quite a few shellcheck warnings

@ELLIOTTCABLE ELLIOTTCABLE force-pushed the clean-up-shell-script branch from 462c237 to 097c063 Compare January 17, 2025 23:30
@ELLIOTTCABLE ELLIOTTCABLE marked this pull request as draft January 17, 2025 23:52
@ELLIOTTCABLE ELLIOTTCABLE force-pushed the clean-up-shell-script branch from 99d1c2b to 668eb2b Compare January 18, 2025 00:02
@ELLIOTTCABLE ELLIOTTCABLE changed the title Fix broken quoting in shell-scripts, as well as making them non-Bash-specific Fix errors in shell-scripts, make installation ask permission before modifying bashrc Jan 18, 2025
@ELLIOTTCABLE ELLIOTTCABLE force-pushed the clean-up-shell-script branch from 2e114e4 to 49a0a77 Compare January 18, 2025 00:09
@ELLIOTTCABLE ELLIOTTCABLE changed the title Fix errors in shell-scripts, make installation ask permission before modifying bashrc Fix errors in shell-scripts, make installation ask permission before modifying bashrc, make POSIX-compatible Jan 18, 2025
@ELLIOTTCABLE
Copy link
Author

In retrospect, I should have made separate PRs; apologies. Didn't realize how many things in the scripts I'd want to clean up once I'd started. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant