-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for custom block models #1332
Draft
leMaik
wants to merge
42
commits into
chunky-dev:master
Choose a base branch
from
leMaik:json-block-models
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leMaik
force-pushed
the
json-block-models
branch
from
October 3, 2022 21:09
a89c73c
to
664366e
Compare
What's the progress? |
@Zhou-Shilin Needs a rebase and is not ready yet. There is a checklist above. |
…ert large blocks to block entities automatically.
…lipped west textures).
…ck not being rendered.
…onverting a block to an entity.
…any dynamic lookups while rendering.
leMaik
force-pushed
the
json-block-models
branch
from
February 18, 2024 21:35
730ae99
to
7ba6d73
Compare
A varied handful of mods and a world for testing 1.20.1 modded block support: World: no errors test.zip Mods: Mods to test.zip (I had to remove a few mods so I didn't go over the upload limit like chipped and MTR) Happy testing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for custom block models. It can (and currently is hard-coded to do so) also replace Chunky's built-in models by models generated from the minecraft jar file.
Caveats:
entityLoadingPreferences
causing them not to load by defaultTintedQuad
and use thetints
array instead (as in hard-coded models)JsonModel
andMultipartJsonModel
shouldn't beBlock
sminecraft:pitcher_plant
To get the latest build of this PR, follow this guide: https://github.com/leMaik/chunky-pr-as-update-site
Due to a bug, you currently have to open the resource pack dialog and apply the resourcepacks after launching this Chunky build. Then it will load the models. Reload the world if you only see purple blocks.
Fixes #88 and fixes #426.