Update to file param in v4l2_fh_{add|del} #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In v6.18 upstream reworked the v4l2_fh_add() and v4l2_fh_del() calls to take the file pointer as argument and handle internally the storage of the v4l2_fh instance under file->private_data, see [1], [2] and [3]. The file pointer associated with the v4l2_fh instaces is also stored under struct virtio_media_queue_state to facilitate calls to virtio_media_session_close() from the virtio_driver->remove() context where the file isn't readily available. Link: https://git.kernel.org/torvalds/c/47f4b1acb4d5 [1] Link: https://git.kernel.org/torvalds/c/277966749f46 [2] Link: https://git.kernel.org/torvalds/c/618882c92681 [3] Signed-off-by: Carlos Llamas <[email protected]> Signed-off-by: Alistair Delva <[email protected]> [adelva: reworked against tot]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v6.18 upstream reworked the v4l2_fh_add() and v4l2_fh_del() calls to take the file pointer as argument and handle internally the storage of the v4l2_fh instance under file->private_data, see [1], [2] and [3].
The file pointer associated with the v4l2_fh instaces is also stored under struct virtio_media_queue_state to facilitate calls to virtio_media_session_close() from the virtio_driver->remove() context where the file isn't readily available.
Link: https://git.kernel.org/torvalds/c/47f4b1acb4d5 [1]
Link: https://git.kernel.org/torvalds/c/277966749f46 [2]
Link: https://git.kernel.org/torvalds/c/618882c92681 [3]
[adelva: reworked against tot]