-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[BLD]: record workflow compute metrics #4670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
52b30c9
to
b3c05ab
Compare
Review SummarySkipped posting 1 drafted comments based on your review threshold. Feel free to update them here. Draft Comments.github/workflows/_go-tests.yml:17-17
Scores:
Reason for filtering: Comment addresses a legitimate security concern with GitHub Actions and provides a specific fix Analysis: While this is a valid security concern about mutable action references, the production impact is moderate since exploitation requires specific circumstances. The fix is very specific (exact version provided) but urgency is medium as it's a preventive security measure rather than an immediate threat. Total score of 11 falls below the 13 threshold. |
WalkthroughThis PR enhances CI observability by adding a telemetry collection step to all major GitHub Actions workflows, including build, test, and nightly jobs. The new step leverages the 'catchpoint/workflow-telemetry-action@v2' action, configured to avoid commenting on pull requests. The change is strictly additive, ensuring no impact on existing build, test, or release logic, and aims to facilitate monitoring and analysis of workflow executions across the project. Changes
Sequence DiagramThis diagram shows the interactions between components: sequenceDiagram
title GitHub Actions Workflow with Telemetry Collection
participant GH as GitHub Actions Runner
participant Checkout as actions/checkout@v4
participant Telemetry as catchpoint/workflow-telemetry-action@v2
participant DockerSetup as ./.github/actions/docker
Note over GH: Workflow starts
GH->>Checkout: Run checkout action
Note over Checkout: Fetches repository with<br/>fetch-depth: 0
Checkout-->>GH: Repository checked out
%% New telemetry action added in PR
GH->>Telemetry: Run workflow telemetry action
Note over Telemetry: Collects workflow telemetry<br/>comment_on_pr: false
Telemetry-->>GH: Telemetry collected
GH->>DockerSetup: Set up Docker
Note over DockerSetup: Configures Docker environment
DockerSetup-->>GH: Docker setup complete
Note over GH: Workflow continues...
Note for Windsurf Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts belowEmoji Descriptions:
Interact with the Bot:
Also you can trigger various commands with the bot by doing The current supported commands are
More commands to be added soon. |
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
pytest
for python,yarn test
for js,cargo test
for rustDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?