Fix BASE16_THEME env set by fish shell helper #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fish shell helper script was using the wrong variable to parse the current theme name from the theme's path, thus setting the BASE16_THEME environment variable to an empty string. This affects scripts or configurations that rely on BASE16_THEME, such as the base16-vim users that use the instructions on the README file (colorschema base16-$BASE16_THEME).
|
I had the same issue. This change works for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fish shell helper script was using the wrong variable to parse the current theme name from the theme's path, thus setting the
BASE16_THEMEenvironment variable to an empty string.This affects scripts or configurations that rely on
BASE16_THEME, such as the base16-vim users that use the instructions on the README file (colorschema base16-$BASE16_THEME).