Add a default variant in addition to the original 256 one #193
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
I'm on MacOS, using base16 since a long time using the iTerm2, Vim and fzf templates.
I'm now using other terminal emulators and more and more Linux. Then I wanted to switch to this base16-shell template, in order to have all of my config depending on my shell config, instead of having having to handle some terminal emulators templates on one side, and the rest inside config files.
But, this base16-shell template only provids the 256 version, which is different from other templates. Then, I propose to implement the default behavior, in addition to the original 256 version.
How
I propose to add a
$BASE16_SHELL_DEFAULT_VARIANT
variable in order to switch to the 16 colors version. It is built not to break the current users configuration: unless this variable is set, the template acts exactly as it already does:What
templates/default.mustache
in order to change different colors depending on the$BASE16_SHELL_DEFAULT_VARIANT
variable stateREADME.md
to reflect new behaviorscripts/base16-*.sh
, using the very last version of Base 16 Builder Pythoncolortest
script to the new template