[Schema] Make Page a plain value object instead of extending ArrayObject - #38
Open
chr-hertel wants to merge 1 commit into
Open
chr-hertel wants to merge 1 commit into
chr-hertel wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops the
\ArrayObjectinheritance fromPage: no more duplicated storage, public mutators on a readonly value object, orARRAY_AS_PROPSproperty/item ambiguity. No caller iterated, counted, or array-accessed aPage— all consumers use thereferencesandnextCursorproperties — so no interface is needed. The fourassertCountcalls inRegistryTestnow count->references, and aPageTestcovers the value object.Closes #17
Confidence: 9/10 — all Page consumers verified via grep to use only the readonly properties; full unit suite, php-cs-fixer, and phpstan are green.