Skip to content

Pull request #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Pull request #4

wants to merge 5 commits into from

Conversation

battika
Copy link

@battika battika commented Jan 12, 2012

Hello,

Please accept my pull request which does two things:

  1. Logs a message when curl fails to execute
  2. Includes a copy of a cacert file in the curl request when dev environment is Windows. In case of Linux the file will not be included.

Any questions please contact me.

Thanks in advance,
Attila

@chok
Copy link
Owner

chok commented Mar 25, 2012

Hi,

Sorry for the wait...

To log the curl error I completely agree but for Windows maybe some of people who use windows don't have this kind of problem. I think it should be better to add an option related to curl to specify the cacert file and why not bundle it and specify in the readme that for Windows user it is possible to have problems and how fix it.

What do you think about that ?

Thanks
Maxime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants