fix(skills): preserve timeout failures and worker deadlines - #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Timeouts could be reported as successful work or disappear behind fallback data. This change fixes four cases together:
ETIMEDOUTresult cannot becomecompletedwhen a termination handler exits zero.Validation: 12 installation-audit tests, 23 catalog tests, 11 dispatcher/manager unit tests and 14 static checks passed. Each of the three runtime regressions fails against the original source. Independent review found no blocking defects and checked the council deadline/settlement cases. The full Linux ARM64 suite passed 158 checks with zero failures; native loop-engineering passed all 99 tests. All five exact-head CI jobs passed: https://github.com/cheshirecode/dotfiles/actions/runs/34731165791.