Conversation
Mateasek
suggested changes
Jan 15, 2025
jacklovell
reviewed
Jan 16, 2025
jacklovell
approved these changes
Jan 17, 2025
Member
jacklovell
left a comment
jacklovell
left a comment
There was a problem hiding this comment.
This looks good to me now, thanks!
The CI failure is due to a change in the default runner: this is fixed (among other things) in #79 so will merge after that has gone in.
vsnever
suggested changes
Jan 20, 2025
Comment on lines
83
to
84
| :param solps_data: Data array defined on the SOLPS mesh | ||
| :return: matplotlib.collections.PolyCollection |
Member
There was a problem hiding this comment.
Please add a description for the collection_kw kwargs.
vsnever
approved these changes
Jan 27, 2025
Mateasek
approved these changes
Jan 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the changes discussed in #80
It adds more flexible functions for plotting while maintaining original functionality.
Two more tutorials are added as well.