mnt: Optimize mntinfo_add_list to O(1) using a tail pointer #2599
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch optimizes the
mntinfo_add_list
function from O(n) to O(1) by introducing a tail pointer (tailbuffer
) to track the end of the linked list. Previously, adding a newmount_info
node required traversing the entire list to find the tail, which was inefficient for large lists.Changes:
struct list_head tail
to themount_info
struct to maintain the tail pointer.tailbuffer
to store the current tail of the list.mntinfo_add_list
to usetailbuffer
for O(1) insertion at the tail.mntinfo_add_list_before
to initialize the tail pointer and maintain consistency when adding nodes at the head.The optimization significantly improves performance for operations involving large lists of mount information. This change also ensures that the list remains consistent and correctly updated during insertions.