Add property for new nan behavior

chbhat10 · Jun 6, 2024 · 8f122fc · 8f122fc
1 parent d19a962
commit 8f122fc
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/presto-main/src/main/java/com/facebook/presto/sql/analyzer/FeaturesConfig.java b/presto-main/src/main/java/com/facebook/presto/sql/analyzer/FeaturesConfig.java
@@ -311,6 +311,8 @@ public class FeaturesConfig
     private CreateView.Security defaultViewSecurityMode = DEFINER;
     private boolean useHistograms;
 
+    private boolean useNewNanDefinition;
+
     public enum PartitioningPrecisionStrategy
     {
         // Let Presto decide when to repartition
@@ -3117,4 +3119,17 @@ public FeaturesConfig setUseHistograms(boolean useHistograms)
         this.useHistograms = useHistograms;
         return this;
     }
+
+    public boolean getUseNewNanDefinition()
+    {
+        return useNewNanDefinition;
+    }
+
+    @Config("use-new-nan-definition")
+    @ConfigDescription("Enable functions to use the new consistent NaN definition where NaN=NaN and is sorted largest")
+    public FeaturesConfig setUseNewNanDefinition(boolean useNewNanDefinition)
+    {
+        this.useNewNanDefinition = useNewNanDefinition;
+        return this;
+    }
 }
diff --git a/presto-main/src/test/java/com/facebook/presto/sql/analyzer/TestFeaturesConfig.java b/presto-main/src/test/java/com/facebook/presto/sql/analyzer/TestFeaturesConfig.java
@@ -272,6 +272,7 @@ public void testDefaults()
                 .setLegacyJsonCast(true)
                 .setPrintEstimatedStatsFromCache(false)
                 .setUseHistograms(false));
+                .setUseNewNanDefinition(false));
     }
 
     @Test
@@ -487,6 +488,7 @@ public void testExplicitPropertyMappings()
                 .put("cte-heuristic-replication-threshold", "2")
                 .put("optimizer.print-estimated-stats-from-cache", "true")
                 .put("optimizer.use-histograms", "true")
+                .put("use-new-nan-definition", "true")
                 .build();
 
         FeaturesConfig expected = new FeaturesConfig()
@@ -699,7 +701,8 @@ public void testExplicitPropertyMappings()
                 .setCteHeuristicReplicationThreshold(2)
                 .setLegacyJsonCast(false)
                 .setPrintEstimatedStatsFromCache(true)
-                .setUseHistograms(true);
+                .setUseHistograms(true)
+                .setUseNewNanDefinition(true);
         assertFullMapping(properties, expected);
     }