Fix: Implement fallback method for acmetool account URL retrieval #546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When acmetool account-url command fails, directly read the URL from filesystem. This ensures cmdeploy dns can proceed even if the acmetool command is not functioning properly. Fixes chatmail#545
…ccount URL retrieval fix
hpk42
reviewed
Apr 9, 2025
| for le_dir in le_dirs: | ||
| acct_dirs = glob.glob(os.path.join(le_dir, "*")) | ||
| for acct_dir in acct_dirs: | ||
| url_file = os.path.join(acct_dir, "url") |
There was a problem hiding this comment.
on two hosts where i can ssh in, this 'url' file does not exist.
|
Hm, we can't reproduce the issue...
have you more informations about these scenarios? Which operating systems did you test? Note that we recommend and only test on Debian 12 machines. |
|
Could you maybe supply the full output for "cmdeploy dns" resulting in acmetool-account-url problems? |
|
I have patched my running configuration already, i'll see if i have the logs still. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where the 'cmdeploy dns' command fails when unable to retrieve the Let's Encrypt account URL through the 'acmetool account-url' command.
Changes:
The changes have been tested and verified to work in scenarios where the acmetool command fails to return the account URL.