feat: set apns-collapse-id for Apple notifications #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is an attempt to prevent this from happening: At 2025-01-28 this is now deployed. If this prevents NSE from creating multiple notifications, we should revert. |
|
please revert deployment and do not merge: this avoids having two notifications at the same time. it seems, client cannot ungroup things grouped by apns-collapse-id - the can only sub-group using some threadIdentifier |
|
This is now reverted on the server back to |
|
Yep but even after(if) that PR merges we'll need to postpone this PR for a while until most people are on the new version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.