feat: Don't scale up Origin of multiple and broadcast recipients when sending a message #7627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sending a message 84161f4 promotes group members to `Origin::IncomingTo` when accepting it instead of `CreateChat` as before, but this changes almost nothing because it happens rarely that the user only accepts a group and writes nothing there soon. Now if a message has multiple recipients, i.e. it's a 3-or-more-member group, or if it's a broadcast message, we don't scale up its recipients to `Origin::OutgoingTo`.
Collaborator
Author
|
I suggest we merge this (if there are no other ideas), otherwise already merged #7616 doesn't make much sense |
Simon-Laux
reviewed
Jan 8, 2026
| assert_eq!(contacts.len(), 2); | ||
| assert_eq!(contacts[0], bob_fiona_id); | ||
|
|
||
| send_text_msg(bob, bob_chat_id, "ehlo".to_string()).await?; |
Contributor
There was a problem hiding this comment.
nitpick: what does "ehlo" mean? is it a typo or a reference to some SMTP command?
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| send_text_msg(bob, bob_chat_id, "ehlo".to_string()).await?; | |
| send_text_msg(bob, bob_chat_id, "Hi Alice, stay down in my contact list".to_string()).await?; |
Let's replace it with a self-documenting message to avoid questions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
84161f4 promotes group members to
Origin::IncomingTowhen accepting it, instead ofCreateChatas before, but this changes almost nothing because it happens rarely that the user only accepts a group and writes nothing there soon. Now if a message has multiple recipients, i.e. it's a 3-or-more-member group, or if it's a broadcast message, we don't scale up its recipients toOrigin::OutgoingTo.Follow-up to #7616
Maybe when accepting a 2-member group it also makes sense to use
Origin::CreateChatas before because it's a "1:1 group"?