fix: Emit MsgsNoticed on receipt of an IMAP-seen message #6415
+96
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iequidoo
force-pushed
the
iequidoo/MsgsNoticed-on-seen-msg
branch
from
d0b64a4 to
d4bd239
Compare
iequidoo
force-pushed
the
iequidoo/MsgsNoticed-on-seen-msg
branch
from
d4bd239 to
9381e8d
Compare
5 tasks
`imap::Session::sync_seen_flags()` emits `MsgsNoticed` for existing messages seen on other devices, so `receive_imf` should do the same when it receives a seen message. Otherwise a multi-device user may see a new message notification on device A, just swipe it, then see another new message notification and mark it as read, and when a device B goes online, it will show a notification for the first message, and it won't be removed because `MsgsNoticed` isn't emitted. I have checked this with my DC Android and Desktop. With this fix the notification can be removed if UIs handle `MsgsNoticed` accordingly, though currently i can't achieve this behaviour in Desktop. Also add blocked chat's messages and silent group changes messages as `InNoticed` instead of `InSeen`, they don't need to cause `MsgsNoticed` events. This doesn't change any UX, checked this in Desktop.
iequidoo
force-pushed
the
iequidoo/MsgsNoticed-on-seen-msg
branch
from
9381e8d to
313a200
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit message.
#6351 (comment) says:
This PR avoids emitting
MsgsNoticedfor the trash chat and adds the corresponding tests for reactions and MDNs.