events: work around the bug in concurrent-queue #2444
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
force-pushed
the
concurrent-queue-workaround
branch
from
22b6090 to
1f77305
Compare
|
Upstream bugreport: smol-rs/concurrent-queue#11 |
r10s
approved these changes
May 14, 2021
|
After checking the source code, I doubt there is a bug. I suspect a hardware problem, suggest @Simon-Laux to run memtest. I don't see any code path that can result in out of bounds access. |
Use power of 2 channel capacity to avoid occasional out of bounds access panic.
link2xt
force-pushed
the
concurrent-queue-workaround
branch
from
1f77305 to
9635fb3
Compare
|
memtest passed without any errors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use power of 2 channel capacity to avoid occasional out of bounds access panic.
Address #2442