Skip to content

Deprecate Subscription.all (import subscriptions endpoint)#144

Merged
wscourge merged 1 commit into
mainfrom
wiktor/pip-40-deprecate-import-subscriptions
May 13, 2026
Merged

Deprecate Subscription.all (import subscriptions endpoint)#144
wscourge merged 1 commit into
mainfrom
wiktor/pip-40-deprecate-import-subscriptions

Conversation

@wscourge
Copy link
Copy Markdown
Contributor

@wscourge wscourge commented May 12, 2026

  • Subscription.all calls GET /v1/import/customers/{customerUuid}/subscriptions, which is deprecated on the API side.
  • Wraps Subscription.all to emit a console.warn deprecation message before delegating to the original method, mirroring the pattern already used for Customer.connectSubscriptions and Customer.disconnectSubscriptions.
  • Existing callers continue to work; consumers should migrate to ChartMogul.Metrics.Customer.subscriptions.

@wscourge wscourge marked this pull request as ready for review May 12, 2026 09:46
@wscourge wscourge requested review from briwa and tudorpavel May 12, 2026 09:46
@wscourge wscourge merged commit d0bdb0e into main May 13, 2026
5 checks passed
@wscourge wscourge deleted the wiktor/pip-40-deprecate-import-subscriptions branch May 13, 2026 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants