fix bug in reduction #136
Open
fix bug in reduction #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, I am not sure what the root cause of that bug is now. All I know is that the reduction test can deadlock, and it just uses a normal reduction. We need to find the root cause. |
|
I think this should fix it, I tried running the reductions on my computer 100 times and the hangs/segfaults seem to go away. This just clears the CmiReduction structs properly in CmiClearReduction. |
|
I got a segmentation fault with this branch. |
|
Also this error reconverse_reduction: ../src/concurrentqueue.h:3408: moodycamel::ConcurrentQueue<T, Traits>::ImplicitProducer* moodycamel::ConcurrentQueue<T, Traits>::get_or_add_implicit_producer() [with T = void*; Traits = moodycamel::ConcurrentQueueDefaultTraits]: Assertion `mainHash != nullptr' failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bug in the node reduction logic that appears to be fixed by setting the reduction id correctly. But I am not sure about the bug mentioned in issue #135. I don't know how that can be a bug, CpvAccess only accesses thread-private variables. Also, this logic is based off the old Converse implementation. @JiakunYan Did you mean that the bug has to do with node reductions (which I have seen fail in the CI before)? I haven't seen issues with regular reductions.