Skip to content

Charge Control C / Development: minor fixes #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: everest/charge_control_c
Choose a base branch
from

Conversation

barsnick
Copy link
Contributor

  • fix example output
  • fix copy command
  • add note about parallel jobs

barsnick added 3 commits June 27, 2025 13:01
Also add `-v` verbose flag to `cp` to visualize what actually happens.

Signed-off-by: Moritz Barsnick <[email protected]>
Recently observed several times on WSL2.

Signed-off-by: Moritz Barsnick <[email protected]>
@barsnick barsnick requested review from lategoodbye and FaHaGit June 27, 2025 11:26

.. code-block:: console

make install -j4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the problem, but in my VM case ( nproc = 2 ) this suggestion would make things worse. Sure you mention to lower the number, but a newbie isn't aware how to figure the right one.

So what about dropping the j parameter for the low memory case?
Or at least explain what is little RAM?
Or mention that VM is usually very constraint regarding resources?

Copy link
Contributor Author

@barsnick barsnick Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, a fixed number may make things worse.

In fact, while this often happens in our VMs, this change addresses a case noticed both by us and by a customer in WSL2: The PC has 12 cores, and assigns all 12 to WSL2, but only reserves limited RAM. This is bound to fail. (The customer just repeated the build until it succeeded.)

Let's find a different way to address this.

Copy link
Member

@lategoodbye lategoodbye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except of the comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants