Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charge SOM: Add logging and debugging section #37

Merged

Conversation

FaHaGit
Copy link
Contributor

@FaHaGit FaHaGit commented Mar 10, 2025

No description provided.

@FaHaGit FaHaGit requested review from lategoodbye and barsnick March 10, 2025 12:01
@FaHaGit
Copy link
Contributor Author

FaHaGit commented Mar 10, 2025

Should be merged after #32

@FaHaGit FaHaGit changed the title ChargeSOM: Add logging and debugging section Charge SOM: Add logging and debugging section Mar 10, 2025
Copy link

@barsnick barsnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the content (at least of this last commit versus the referenced branch) is identical to what is already upstream for CCC), this looks good.

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

No, the Control Pilot interface on ChargeSOM is not able to operate as an EV. Please look at
our `website <https://www.chargebyte.com/>`_ for more suitable products.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically this is not 100% correct. I would say that the hardware of the ChargeSOM is not designed for the EV use case.

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

The ChargeSOM doesn't have an `EVerest admin panel <https://github.com/EVerest/everest-admin-panel>`_
because of its limited resources. Please use your development environment to set up your configuration
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bad argument, because the ChargeSOM has enough resources.

Does EVerest on ChargeSOM support ISO 15118-20 yet?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

The required module for ISO 15118-20 has been included in the image since the chargebyte EVerest 0.2.0 release.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to call it Charge SOM EVerest release to be more clear.

@lategoodbye
Copy link
Member

Github Actions complains about undefined labels, could you please check that?

undefined label: 'firmware_customization'
undefined label: 'programming'

@FaHaGit
Copy link
Contributor Author

FaHaGit commented Mar 11, 2025

Github Actions complains about undefined labels, could you please check that?

undefined label: 'firmware_customization' undefined label: 'programming'

This message is expected, because the firmware section is not yet integrated. I would merge it as soon as the firmware section it integrated.

@FaHaGit FaHaGit merged commit 15cdfd6 into everest/charge_som Mar 14, 2025
1 check passed
@FaHaGit FaHaGit deleted the everest/charge_som-add-logging-and-debugging branch March 14, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants