Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCC: Introduce generic firmware chapter #35

Merged
merged 6 commits into from
Mar 10, 2025

Conversation

lategoodbye
Copy link
Member

@lategoodbye lategoodbye commented Mar 6, 2025

This is the preparation to integrate the firmware chapter in Charge SOM user guide. Additionally it contains a restructure/prioritization of the firmware upgrade.

In case of small text changes, please comment the last commit.

Fix some missing or invalid links

Signed-off-by: Stefan Wahren <[email protected]>
Move the more important information to the top:
- move chapter Firmware Upgrade after Introduction
- make section Download Firmware Images the first one of Firmware Upgrade
- move section Update variants after Device Access

Signed-off-by: Stefan Wahren <[email protected]>
Copy link

@simonseres simonseres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@FaHaGit FaHaGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

During recent review, there were some minor issues found. This
commit addresses them.

Signed-off-by: Stefan Wahren <[email protected]>
@lategoodbye lategoodbye requested a review from barsnick March 10, 2025 09:46
Copy link

@barsnick barsnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. LGTM now.

@lategoodbye lategoodbye merged commit 9d1e1a4 into everest/charge_control_c Mar 10, 2025
1 check passed
@lategoodbye lategoodbye deleted the everest/ccc_generic_firmware branch March 10, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants