Skip to content

Conversation

@Devatoria
Copy link
Contributor

@Devatoria Devatoria commented Jun 6, 2019

This PR is related to issue #39

  • scope actions and probes
  • (re)write actions and probes tests

Devatoria added 2 commits June 6, 2019 10:07
Signed-off-by: Devatoria <[email protected]>
Signed-off-by: Devatoria <[email protected]>
@Lawouach
Copy link
Contributor

Lawouach commented Jun 6, 2019

You are awesome @Devatoria ! :)

@Lawouach Lawouach added the needs-changes Waiting for PR changes label Dec 1, 2019
@tdevilleduc
Copy link
Contributor

Is there something to improve here ?
I was thinking about moving all functions from chaosk8s/probes.py to differents folders:

  • deployment_is_not_fully_available, deployment_is_fully_available, microservice_available_and_healthy, and microservice_is_not_available to deployment/probes.py
  • service_endpoint_is_initialized to service/probes.py
  • I don't know about all_microservices_healthy

Should I commit directly on @Devatoria repository ?

@Lawouach
Copy link
Contributor

I think moving things around is a good idea.

Maybe keeping existing modules with the functiin linking to the appropriate ones but with a warning when they are used from there?

Also, the whole business of "microservice" was a stupidity of mine, it's just a top-down deployment to pod set of functions. Should they remain that way?

@tdevilleduc
Copy link
Contributor

I've created a pull request to DataDog repository
Let's hope he will find it !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-changes Waiting for PR changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants