enable systemctl reload diod + minor logging improvements #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garlick
force-pushed
the
logging
branch
2 times, most recently
from
c7b5921 to
12c9f91
Compare
|
Derp. Botched a test there but it's fixed now. |
grondo
approved these changes
Jan 20, 2025
| @@ -26,15 +26,27 @@ | |||
|
|
|||
| #include "diod_log.h" | |||
|
|
|||
| static char *prog = NULL; | |||
|
|
|||
| static char log_prefix[32] = { 0 }; | |||
There was a problem hiding this comment.
commit message nit: "some TAP unit test" -> "some TAP unit tests"
There was a problem hiding this comment.
Thanks! Fixed and I'll set MWP.
Problem: some TAP unit tests emit debug output prefixed with "#: ", which is legal TAP but looks funny. Change diod_log_init() to not append ": " to the log prefix if it already ends in a space, and change the test server to do that. Also skip the log prefix if diod_log_init() is called with a NULL argument, anticipating the next commit.
Problem: the "diod: " log prefix is not helpful because server logging is rarely mixed with output from other programs. Or if it is, it's been processed through the systemd journal or syslog which also adds its own prefix. Initialize server logging with no prefix.
Problem: it may be useful, especially when debugging, to know what ports and interfaces diod is listening on. Log this when diod starts up. Update tests/misc/t15 for this change and clean up its Makefile.am.
Problem: diod supports runtime configuration reloading but the systemd unit file doesn't. Arrange to send SIGHUP to diod when an admin runs systemctl reload diod.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The systemd unit file is modified so that
systemctl reload diodcan be used to modify the exports config without completely restarting.In addition, this tweaks logging slightly