diod: do not daemonize, do not syslog #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: diod_sock.c defined some globals for TCP Wrappers, but support for it was removed so they are now unused. Drop the unused globals.
Problem: diod can log directly to syslog, but these days that can be handled in other ways. For example, stderr is typically redirected to the systemd journal, which can be redirected to syslog. Drop the direct syslog logging capability from diod. Drop syslog.h from several source files. Update unit test.
Problem: logging to syslog is deprecated but man pages still describe it, and it appears in the example config file. Drop syslog from the man pages. Change the example log config to a filename.
Problem: diod puts itself in the background by default, but this can be confusing and unexpected when running the service manually. In fact, given that systemd can manage daemons running in the foreground, it is probably no longer useful at all. Drop the --foreground option and never daemonize. Update tests.
Problem: diod dropped its --foreground option but the man page still describes it. Drop it from the man page.
Problem: diod now runs in the foreground, but systemd thinks it is going to fork. Change to Type=exec. See also systemd.exec(5).
grondo
approved these changes
Jan 19, 2025
People do run diod on FreeBSD (or have in the past) and in busy box environments where there is no systemd. However I don't think that poses a problem:
I should have noted that in the description, so thanks for bringing it up. There is also the fact that philosophically speaking 9P is about as far as you can get from the "toss it all in" apparent guiding principle of systemd so I wouldn't want to imply that it's required for diod! |
|
Thanks for the clarification! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since systemd (and probably other pid ones) can manage daemons running in the foreground and capture stderr, drop diod's capability to daemonize and log to syslog to keep things simple.
As a bonus it avoid the unexpected WTF? when you manually run
diodand nothing apparently happens (because it backgrounded itself).