Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(multiome): Update the upload_local_datafile_to_dataset.ipynb to use a manifest. #1288

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

Bento007
Copy link
Contributor

@Bento007 Bento007 commented Mar 7, 2025

Reason for Change

  • Now that the manifest endpoint is used to upload datasets from the submission bucket, the notebook upload_local_datafile_to_dataset must be updated to use the new work flow. Now local files are uploaded to s3, and the resulting s3_uri will populate the manifest. The manifest submission endpoint will be called with the newly uploaded files and ingestion will start.

Changes

  • update the upload_local_datafile to return an s3_uri
  • Use the local file name i the s3 object key.
  • update upload_local_datafile_to_dataset to use the manifest endpoint and build the manifest.

Testing

Notes for Reviewer

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.29%. Comparing base (50c98d3) to head (d12e3bb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1288      +/-   ##
==========================================
- Coverage   89.33%   89.29%   -0.05%     
==========================================
  Files          21       21              
  Lines        2373     2373              
==========================================
- Hits         2120     2119       -1     
- Misses        253      254       +1     
Components Coverage Δ
cellxgene_schema_cli 89.93% <ø> (-0.06%) ⬇️
migration_assistant 91.26% <ø> (ø)
schema_bump_dry_run_genes 79.74% <ø> (ø)
schema_bump_dry_run_ontologies 99.53% <ø> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Bento007 Bento007 merged commit cde8485 into main Mar 7, 2025
12 of 14 checks passed
@Bento007 Bento007 deleted the tsmith/update-upload branch March 7, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants