feat: schema 5.3.0 gene bumps #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1286 +/- ##
==========================================
- Coverage 89.33% 89.29% -0.05%
==========================================
Files 21 21
Lines 2373 2373
==========================================
- Hits 2120 2119 -1
- Misses 253 254 +1
🚀 New features to boost your workflow:
|
ejmolinelli
force-pushed
the
ejmolinelli/5.3.0
branch
2 times, most recently
from
603ba15 to
0612226
Compare
added 9 commits
March 10, 2025 10:29
ejmolinelli
force-pushed
the
ejmolinelli/5.3.0
branch
from
d7ec712 to
aa788de
Compare
joyceyan
reviewed
Mar 10, 2025
| run_reporter.public_errored_datasets += 1 | ||
| logger.error( | ||
| f"Error processing public dataset {dataset['dataset_id']}, in collection {dataset['collection_id']}: " | ||
| f"{e}" |
There was a problem hiding this comment.
is there any reason why we would not want to log the actual exception that occurred?
joyceyan
reviewed
Mar 10, 2025
| run_reporter.private_errored_datasets += 1 | ||
| logger.error(f"Error processing private dataset: {e}") | ||
| logger.error("Error processing private dataset") |
There was a problem hiding this comment.
i understand that we don't want to log stuff about private datasets
There was a problem hiding this comment.
For expedience only. We have another issue to handle meaningful logs.
joyceyan
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change
Update (a) gene info files and (b) COG version to comply with cxg schema 5.3.0.
Changes
Testing
version to PyPI without explicit QA + sign-off from Lattice on all functional CLI changes. They may install the package
version at HEAD of main with
Notes for Reviewer