fix: add rerun-if-changed, remove .git in w2c2, update cc version
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build_w2c2.sh
Outdated
| @@ -16,6 +16,7 @@ fi | |||
|
|
|||
| rm -rf $BUILD_DIR | |||
| git clone --recursive https://github.com/turbolent/w2c2 $BUILD_DIR | |||
| rm -rf $BUILD_DIR/.git | |||
There was a problem hiding this comment.
Why do we need to remove this .git dir? This is in a temporary directory
There was a problem hiding this comment.
when I used mopro CLI to create a mopro-example-app
(Now it doesn't ignore the target/. Actually we should fix this)
but it tracks the w2c2 git status
but I think it is optional. I can also revert this.
Do you think we should keep the git status here?
There was a problem hiding this comment.
Ah this script isn't using a tmpdir. Instead of removing the .git directory it's probably better to run these commands in a temporary directory.
There was a problem hiding this comment.
I revert the change
3461769
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add
println!("cargo:rerun-if-changed={}", wasmdir);If there is a change in
wasmdir, rerun transpileFix: Error with caches in
rust-witnesszkmopro/mopro#298remove
.gitstatusif the directory is without
.git, it tracks thetarget/.gitstatusupdate
ccversion