fix: generated CssVarKeys type cannot provide autocomplete correctly
#3177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ae6836a The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hyp3rflow
force-pushed
the
fix/css-var-autocomplete
branch
from
dccabc3 to
ae6836a
Compare
hyp3rflow
commented
Mar 13, 2025
| @@ -8,8 +8,8 @@ type AnyString = (string & {}) | |||
| type CssVars = `var(--${string})` | |||
| type CssVarValue = ConditionalValue<Token | AnyString | (number & {})> | |||
|
|
|||
| type CssVarName = | AnyString | |||
| type CssVarKeys = `--${CssVarName}` | |||
| type CssVarName = | |||
There was a problem hiding this comment.
How can I prevent this empty type? I tried to fix this by editting style-props.ts, but it didn't work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
📝 Description
Fix issue where generated
CssVarKeystype cannot provide autocomplete correctly⛳️ Current behavior (updates)
It provides suggestion as if it is just
stringtype.🚀 New behavior
Correctly provides declared css variable keys along with
stringtype.💣 Is this a breaking change (Yes/No): No
📝 Additional Information
You can easily see the difference of this PR in ts playground: https://www.typescriptlang.org/play/?#code/C4TwDgpgBGDCDO8BqBDATgORQW2gXigHIBrCEAWhUKgB8jSKAjaugCnmDQEsA7AcygAyKAG8AvgEoAUKEgwEydAGkyUAgANy5ACQi4iVJhwQx6qQHpzUawD0A-FJnhoPBYay419MpRbemhE5yrgbKqhpauiGKRrimtFCaOiIc3PzxwuIWVrZ2QA