refactor(authz): replace admin role check with policy-based authorization for default backend access#2741
Merged
migmartri merged 1 commit intochainloop-dev:mainfrom Feb 15, 2026
Conversation
Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
migmartri
requested review from
javirln and
jiparis
and removed request for
jiparis
migmartri
commented
Feb 13, 2026
| backend = defaultBackend | ||
| } else { | ||
| // fallback to default backend if the user or the token is allowed to | ||
| if ok, err := s.authzUC.Enforce(ctx, currentAuthzSubject, authz.PolicyDefaultBackendArtifactRead); err != nil { |
Member
Author
There was a problem hiding this comment.
this will allow us to customize API tokens with PolicyDefaultBackendArtifactRead
jiparis
approved these changes
Feb 15, 2026
Member
|
Nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace hardcoded admin role check with proper policy-based authorization when falling back to the default CAS backend for artifact downloads.
Motivation
This change improves the authorization model by: