-
Notifications
You must be signed in to change notification settings - Fork 42
chore(attestations): Include attestation links on att push #2670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -179,7 +179,10 @@ controlplane: | |
|
|
||
| ## @skip controlplane.restrictOrgCreation Restrict organization creation to instance admins | ||
| restrictOrgCreation: false | ||
|
|
||
|
|
||
| ## @param controlplane.platformExternalUrl Optional external URL for the platform UI. If set, CLI will display attestation view links after push | ||
| platformExternalUrl: "" | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
|
|
||
| ## @extra controlplane.nats optional NATS configuration for events publishing. | ||
| ## @param controlplane.nats.enabled Enable events publishing through a Nats stream | ||
| ## @param controlplane.nats.host NATS Host | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe this should come in the
initand stored in the crafting state? That would be more in line on how the attestation process gets context today no?