feat(api): add team field to WorkflowRef message #2651
+45
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add optional team field to WorkflowRef message to provide team context when referencing workflows in contract responses. This brings WorkflowRef in line with WorkflowItem which already includes team information. Changes: - Add team field to WorkflowRef protobuf message - Update business layer WorkflowRef struct - Update data layer to populate team from workflow entity - Update service layer conversion to include team - Update CLI action layer to handle team in JSON output - Update CLAUDE.md with correct copyright year (2026) Signed-off-by: Miguel Martinez <[email protected]>
migmartri
changed the title
Member
|
I thought we were going to remove the |
Member
Author
yes it is, although behind I am implementing it to maintain feature parity, but let's discuss the deprecation of team |
Signed-off-by: Miguel Martinez <[email protected]>
javirln
reviewed
Jan 9, 2026
|
|
||
| func pbWorkflowRefToAction(in *pb.WorkflowRef) *WorkflowRef { | ||
| return &WorkflowRef{ID: in.GetId(), Name: in.GetName(), ProjectName: in.GetProjectName()} | ||
| return &WorkflowRef{ID: in.GetId(), Name: in.GetName(), ProjectName: in.GetProjectName(), Team: in.GetTeam()} |
Member
There was a problem hiding this comment.
Is the team needed to identify a Workflow? Isn't it enough with the ID or Name?
Member
Author
There was a problem hiding this comment.
it is used in the UI though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add optional team field to WorkflowRef message to provide team context when referencing workflows in contract responses.
This change extends the WorkflowRef message to include the team field, aligning it with WorkflowItem which already exposes team information. The team field is populated from the workflow entity and included in API responses for workflow contract describe and list operations.
Changes
The change is fully backward compatible as the team field is optional.