feat(policies): Chainloop discover custom builtin#2558
Merged
migmartri merged 1 commit intochainloop-dev:mainfrom Nov 17, 2025
Merged
feat(policies): Chainloop discover custom builtin#2558migmartri merged 1 commit intochainloop-dev:mainfrom
migmartri merged 1 commit intochainloop-dev:mainfrom
Conversation
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
migmartri
approved these changes
Nov 17, 2025
| // } | ||
| // | ||
| // ``` | ||
| func RegisterDiscoverBuiltin(conn *grpc.ClientConn) error { |
Member
There was a problem hiding this comment.
one thing it would be nice to do (in the future) is to generate documentation of these built-in. We do smth for integrations already, like creating a markdown that then we can sync somewhere.
| // } | ||
| // | ||
| // ``` | ||
| func RegisterDiscoverBuiltin(conn *grpc.ClientConn) error { |
Member
There was a problem hiding this comment.
I think that in the future the input should evolve to a struct, so we can have controlplaneConnection, CAS, and platform connections if needed.
| }, getDiscoverImpl(conn)) | ||
| } | ||
|
|
||
| func getDiscoverImpl(conn *grpc.ClientConn) topdown.BuiltinFunc { |
Member
There was a problem hiding this comment.
it would be nice to have logger support, so when running devel with --debug we can see some info
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the CLI to support access to the Discover endpoint as a custom Rego builtin function. This is an example of extending the engine using the extension mechanism provided in #2552
To use it in policies: