feat(s3): migrate from AWS SDK v1 to v2#2497
Merged
migmartri merged 2 commits intochainloop-dev:mainfrom Nov 1, 2025
Merged
Conversation
Migrated the S3 blob manager to use AWS SDK for Go v2, replacing the deprecated v1 SDK. This modernizes the codebase and ensures continued support and security updates. Key changes: - Updated imports to use aws-sdk-go-v2 packages - Replaced session-based config with LoadDefaultConfig pattern - Migrated S3 client and manager APIs - Updated error handling to use smithy APIError - Normalized metadata keys to lowercase for v2 compatibility - Removed aws-sdk-go v1 dependency All existing functionality preserved including custom endpoint support for Minio and Cloudflare R2. Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
Upgraded all Sigstore KMS provider packages from v1.8.8 to v1.9.5 to get latest bug fixes and improvements. This upgrade also updates transitive dependencies for cloud provider SDKs. Updated packages: - github.com/sigstore/sigstore/pkg/signature/kms/aws v1.9.5 - github.com/sigstore/sigstore/pkg/signature/kms/azure v1.9.5 - github.com/sigstore/sigstore/pkg/signature/kms/gcp v1.9.5 - github.com/sigstore/sigstore/pkg/signature/kms/hashivault v1.9.5 These upgrades include transitive updates to: - AWS SDK v2 KMS service (v1.38.3) - Azure SDK and Azure Identity (v1.18.0, v1.10.0) - GCP SDKs for KMS, Storage, Secret Manager - HashiCorp Vault API (v1.16.0) Note: v1.9.5 is the latest stable release on the v1.x branch. The main branch already has AWS SDK v1 removed, which will be available in the next major release. Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
migmartri
requested review from
Piskoo and
jiparis
and removed request for
jiparis
jiparis
approved these changes
Oct 29, 2025
javirln
reviewed
Oct 30, 2025
|
|
||
| // Configure AWS config with v2 SDK | ||
| cfg, err := config.LoadDefaultConfig( | ||
| context.TODO(), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated S3 blob manager and upgraded Sigstore KMS packages to remove AWS SDK v1 dependency.
S3 Blob Manager Migration
Migrated from AWS SDK v1 to v2. The v1 SDK is deprecated and this ensures continued support and security updates.
Sigstore KMS Packages Upgrade
Upgraded all KMS provider packages from v1.8.8 to v1.9.5 for latest improvements and cloud SDK updates:
fixes #2496