Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typos in unit test descriptions #250

Merged
merged 2 commits into from
Jan 6, 2025
Merged

fix: typos in unit test descriptions #250

merged 2 commits into from
Jan 6, 2025

Conversation

vtjl10
Copy link
Contributor

@vtjl10 vtjl10 commented Jan 6, 2025

Corrected it("should should allow to it("should allow
Corrected (bedrock" to (bedrock)"

@cgewecke cgewecke changed the title fix: typos in documentation files fix: typos in unit test descriptions Jan 6, 2025
@cgewecke cgewecke changed the base branch from master to stage_ext_pr_250 January 6, 2025 20:53
@cgewecke cgewecke self-requested a review January 6, 2025 20:54
cgewecke
cgewecke approved these changes Jan 6, 2025
View reviewed changes
Copy link
Owner

@cgewecke cgewecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

(Merging into a staging branch first to make sure CI passes. Some tests depend on environment variables that aren't exposed to pull requests from forks unfortunately.)

@cgewecke cgewecke merged commit d4430ca into cgewecke:stage_ext_pr_250 Jan 6, 2025
2 of 3 checks passed
@cgewecke cgewecke mentioned this pull request Jan 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgewecke cgewecke cgewecke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtjl10 @cgewecke