Skip to content

Develop eodrh7#369

Open
lel99999 wants to merge 39 commits intocfpb:developfrom
lel99999:develop_eodrh7
Open

Develop eodrh7#369
lel99999 wants to merge 39 commits intocfpb:developfrom
lel99999:develop_eodrh7

Conversation

@lel99999
Copy link
Copy Markdown
Contributor

@lel99999 lel99999 commented May 4, 2019

No description provided.

eod_license_server_host:
eod_license_server_cache:

# TODO: you can put all the keys you want to here
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably want to put the actual eod_license _keys in aurora-internal repo behind CPFB enterprise GH

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Copy Markdown
Contributor

@tanderegg tanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lel99999 Left a number of comments, please respond if you have any questions. In general, looks like there is a duplicate of all the template files, and you'll need to do a pass to remove commented out code. Thanks!

Comment thread deploy/Vagrantfile Outdated
Comment thread deploy/deploy_eod7.yml Outdated
Comment thread deploy/deploy_eod7.yml Outdated
eod_license_server_host:
eod_license_server_cache:

# TODO: you can put all the keys you want to here
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread deploy/roles/eod7/defaults/main.yaml Outdated
Comment thread deploy/roles/eod7/tasks/main.yaml Outdated
Comment thread deploy/roles/eod7/tasks/main.yaml
Comment thread deploy/roles/eod7/tasks/main.yaml Outdated
Comment thread deploy/roles/eod7/tasks/main.yaml
Comment thread deploy/templates/20-no-show-proxy-dialog.pkla
Copy link
Copy Markdown
Contributor

@tanderegg tanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lel99999 Almost there, just a few more comments to address, thanks!

Comment thread deploy/deploy_research_environment.yml Outdated
Comment thread deploy/deploy_research_environment.yml Outdated
}
}
# interact return
expect eod
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lel99999 This file should go in the eod7 role right? Also, the binary file above should not be checked in, you'd have to download a copy locally and make sure the Ansible scripts have a variable you can use to point to the right place.

@@ -0,0 +1,20 @@
---
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lel99999 The .swo file above should not be checked in.

command: systemctl start "{{ item }}"
with_items:
- iptables
- ip6tables
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lel99999 These commands should have a when statement to ensure they are only run when using Vagrant.

Comment thread deploy/roles/eod7/tasks/main.yaml
dest: /etc/X11/xorg.conf
notify:
- restart gdm
# - restart prefdm
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lel99999 Remove commented out lines please, thanks!

Comment thread deploy/roles/eod7/tasks/main.yaml
Comment thread deploy/roles/eod7/tasks/main.yaml Outdated
- eod

- name: install iptables-service
command: yum -y install iptables-services
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lel99999 This should also have a when condition.

Comment thread deploy/roles/iptables/tasks/main.yml Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants